Infra: Use dark grey instead of dark green for dark theme background#2977
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
JelleZijlstra pushed a commit to JelleZijlstra/peps that referenced this pull request Jan 24, 2023
…ython#2977) * Use #121212 for dark theme bgcolor * Use #1111111 for dark theme bgcolor Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without wanting to bikeshed too much!
The dark theme's current background colour has a bit of a greenish tint:
#001111(labelled "Dark Green" on some sites) which looks a bit off.The background shouldn't be pure black, the contrast is too high. Here's what a few other sites use:
#0d1117GitHub#121212Google's Material Design#202020Furo#202124Google#2d2d2dStack OverflowPreviews:
Material Design's
#121212is often suggested (1, 2, 3, 4) so I've gone for that.No contrast errors at https://wave.webaim.org/report#/https://hugovk-peps.readthedocs.io/en/dark-bgcolor/ or https://wave.webaim.org/report#/https://hugovk-peps.readthedocs.io/en/dark-bgcolor/pep-0008.
Demo
https://pep-previews--2977.org.readthedocs.build/