Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jun 26, 2023


📚 Documentation preview 📚: https://pep-previews--3182.org.readthedocs.build/

@vstinnervstinner requested a review from benjaminp as a code ownerJune 26, 2023 12:56
@vstinner
Copy link
MemberAuthor

@vstinner
Copy link
MemberAuthor

@pfmoore: I addressed some of your comments.

@vstinner
Copy link
MemberAuthor

For people interested about the exact implementation of SoftDeprecationWarning: I created the PR python/cpython#106142.

@vstinner
Copy link
MemberAuthor

@pfmoore: I rephrased the section. Would you mind to review the updated PR?

@vstinner
Copy link
MemberAuthor

I replaced MUST with SHOULD:

A soft deprecation can be used when using an API which must no longer be used to write new code

becomes:

A soft deprecation can be used when using an API which should no longer be used to write new code

@vstinnervstinner marked this pull request as draft June 28, 2023 03:06
@vstinner
Copy link
MemberAuthor

I mark this PR as a draft to prevent merging it by mistake. I will request SC approval to merge it once it will be ready.

Copy link
Member

@pfmoorepfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks. I've suggested one minor change.

@pfmoore
Copy link
Member

Also, note the discussion on Discourse is still ongoing - I favour the idea of removing the association between "deprecated" and "scheduled for removal", in favour of explicitly flagging things that are planned for removal.

@vstinner
Copy link
MemberAuthor

I updated the PR to no longer issue a warning.

@vstinner
Copy link
MemberAuthor

I submitted this PEP change to the Steering Council: python/steering-council#199

@vstinner
Copy link
MemberAuthor

"The SC agrees with the proposal and accepts the PEP update": python/steering-council#199 (comment)

@vstinnervstinner marked this pull request as ready for review July 3, 2023 19:23
@vstinnervstinner requested a review from a team as a code ownerJuly 3, 2023 19:23
@vstinnervstinner merged commit 57b1d94 into python:mainJul 3, 2023
@vstinnervstinner deleted the soft-deprecation branch July 3, 2023 19:25
@vstinner
Copy link
MemberAuthor

Thanks for the reviews!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@pfmoore@hugovk@Yhg1s@eli-schwartz