Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Dec 18, 2023

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

Helps #2872.

Also replace some old BPO links with their more accessible GitHub issue equivalents, and update some code block formatting.


📚 Documentation preview 📚: https://pep-previews--3596.org.readthedocs.build/

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsalpablogsal merged commit 228851c into python:mainDec 18, 2023
@hugovkhugovk deleted the pep617-mark-as-final branch December 18, 2023 21:28
@hugovkhugovk mentioned this pull request Dec 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@lysnikolaou@pablogsal