PEP 735: Add the acceptance post to Post-History#4053
Uh oh!
There was an error while loading. Please reload this page.
Conversation
| Topic: Packaging | ||
| Created: 20-Nov-2023 | ||
| Post-History: `14-Nov-2023 <https://discuss.python.org/t/29684>`__, `20-Nov-2023 <https://discuss.python.org/t/39233>`__ | ||
| Post-History: `14-Nov-2023 <https://discuss.python.org/t/29684>`__, `20-Nov-2023 <https://discuss.python.org/t/39233>`__, `10-Oct-2024 <https://discuss.python.org/t/39233>`__ |
There was a problem hiding this comment.
Is there a typo? The last two links are identical.
There was a problem hiding this comment.
I didn't follow the whole discussion but this post might have some context: https://discuss.python.org/t/pep-735-dependency-groups-in-pyproject-toml/39233/328. I think the current procedure should be to add a link to the acceptance post in the Resolution field.
There was a problem hiding this comment.
(Which is already there, so I don't know why we need this change at all)
There was a problem hiding this comment.
Yeah, we have two threads in the Post-History, and a direct link to the acceptance message in Resolution. This is correct.
The CI will also fail if you put a message in Post-History.
There was a problem hiding this comment.
Yeah, it looks like I somehow mixed up the links... My intent was to link to the acceptance post.
But I'll wait for #4054 and then I can just make this PR do that. 😄
JelleZijlstra commented Oct 16, 2024
Replaced with #4061 |
sirosen commented Oct 16, 2024
Thanks so much for including this over there! |
3 participants
PEP 123: Summary of changes)It's not clear that this is strictly necessary, but adding a final link to the post-history, to the acceptance post, makes the post and the date more discoverable.
This was raised in Discourse, and I thought it best to take some mild action to address it.
📚 Documentation preview 📚: https://pep-previews--4053.org.readthedocs.build/