Add benchmark for Docutils#216
Uh oh!
There was an error while loading. Please reload this page.
Conversation
mdboom left a comment
mdboom left a comment There was a problem hiding this comment.
This is a good choice for benchmark -- real-world workload over a non-trivial codebase.
In the interest of repository size, would it be possible to remove the images? I don't think docutils does much with them, other than linking to them (though correct me if I'm mistaken), so maybe we only need to include one blank image and adjust all of the links to point to that.
pyperformance/data-files/benchmarks/bm_docutils/run_benchmark.py Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner commented Jun 17, 2022
I blanked every image file, so the files are still there but empty. I also removed every active I moved the I/O to be outwith the timing code, I couldn't think of anything better. A |
AA-Turner commented Jun 17, 2022
I have no clue what is causing CI to fail, when I ran the A |
mdboom commented Jun 17, 2022
I think the clue might be in here: In some case during the test run, the new benchmark function is returning a time that is zero. You could try to reproduce this locally by running: |
mdboom left a comment
mdboom left a comment There was a problem hiding this comment.
Thanks for addressing my concerns. I'm approving this pending CI passing.
pyperformance/data-files/benchmarks/bm_docutils/run_benchmark.py Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Michael Droettboom <mdboom@gmail.com>
AA-Turner commented Jun 27, 2022
@ericsnowcurrently / @gvanrossum you've both committed recently, if you've any time for a review of this PR I'd appreciate it! Thanks A |
gvanrossum commented Jun 27, 2022
Can I bow out? Eric and/or Mike will be able to review this. |
| elapsed = 0 | ||
| for file in doc_root.rglob("*.txt"): | ||
| file_contents = file.read_text(encoding="utf-8") | ||
| t0 = time.perf_counter_ns() |
There was a problem hiding this comment.
| t0=time.perf_counter_ns() | |
| t0=pyperf.perf_counter() |
| "output_encoding": "unicode", | ||
| "report_level": 5, | ||
| }) | ||
| elapsed += time.perf_counter_ns() - t0 |
There was a problem hiding this comment.
| elapsed+=time.perf_counter_ns() -t0 | |
| elapsed+=pyperf.perf_counter() -t0 |
pyperformance/data-files/benchmarks/bm_docutils/run_benchmark.py Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
mdboom commented Aug 1, 2022
@AA-Turner: It would be great to have this. Any chance you have time to address @kumaraditya303's concerns? |
AA-Turner commented Aug 28, 2022
@mdboom / @kumaraditya303 sorry for the delay here, please may you re-review? A |
5 participants
This adds a benchmark of Docutils as an application. I thought a reasonable test load was Docutils' own docs (takes ~4.5-5s on my computer).
I haven't submitted a benchmark before---I don't know the best way of storing the input data, so for speed I copied the documentation into git here (the docs are public domain).
A