Skip to content

Zipimport#840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JulienPalard merged 8 commits into from
Jul 26, 2019
Merged

Zipimport #840

JulienPalard merged 8 commits into from
Jul 26, 2019

Conversation

@Zepmanbc
Copy link
Contributor

@ZepmanbcZepmanbc commented Jul 18, 2019

closes#836

JulienPalard
JulienPalard requested changes Jul 19, 2019
View reviewed changes
@Zepmanbc
Copy link
ContributorAuthor

Zepmanbc commented Jul 20, 2019

@JulienPalard tu disais que tu pouvais faire powrap directement sur github, tu fais comment?

@JulienPalard
Copy link
Member

JulienPalard commented Jul 21, 2019

@Zepmanbc Pas "directement sur github" mais "au merge".

  • Je fetch ta branche localement
  • Je la powrap sur ma machine
  • Je git merge --squash ta branche sur la 3.7

L'inconvénient de merger une branche en dehors de github c'est que github marque la PR comme "closed" plutôt que "merged", j'ai une issue ouverte chez eux pour faire évoluer ça mais ça bouge pas vite :)

@JulienPalard
Copy link
Member

JulienPalard commented Jul 26, 2019

👍

@JulienPalardJulienPalard merged commit 769f723 into python:3.7Jul 26, 2019
@ZepmanbcZepmanbc deleted the zipimport branch May 1, 2020 07:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalardJulienPalardJulienPalard requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Je travaille sur zipimport.po

2 participants

@Zepmanbc@JulienPalard