Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Jul 27, 2023

@hugovkhugovk added the bug label Jul 27, 2023
@hugovkhugovk marked this pull request as ready for review July 27, 2023 11:47
@pradyunsg
Copy link
Member

pradyunsg commented Jul 27, 2023

In Furo, I went ahead and set break-word on the entire content container in pradyunsg/furo@c8b51d0

That makes it so that no regular text/markup, including really long one-word titles don't trigger a rewrap by default, would have an overflow beyond that element.

Do you think it's worth adopting a similar model here?

@hugovk
Copy link
MemberAuthor

Yes, that sounds better, would you like to update this PR or create a new one?

@hugovk
Copy link
MemberAuthor

Updated, how does this look?

Copy link
Member

@pradyunsgpradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugovkhugovk merged commit c98e976 into python:mainJul 30, 2023
@hugovkhugovk deleted the mobile-wrap-long-code-literals branch July 30, 2023 14:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrap lines of code to prevent empty horizontal scroll

3 participants

@hugovk@pradyunsg@AA-Turner