"Updated Sidebar Design and Responsiveness"#212
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Wulian233 commented Jan 20, 2025
I suggested not to delete unnecessary spaces/indentations too much, as this is an unnecessary change. Also, why did you open two PRs for the same content? You could have completed it in the same PR #211 |
ONKARBH commented Jan 20, 2025
Hi! Thank you for your valuable feedback. I completely understand the concern regarding unnecessary changes in spaces and indentations. I'll make sure to avoid those in the future to keep things clean and focused on the actual functionality. As for the two PRs, I initially thought separating the changes would improve clarity, but I now see how combining them into a single PR would be more efficient. I’ll make sure to do that moving forward. Thank you for guiding me through this, and I really appreciate your support! Looking forward to contributing more efficiently. |
| --middle-border:var(--middle-color); | ||
| --bad-color:rgb(244,76,78); | ||
| --bad-border:var(--bad-color); | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Delete these. They were accidentally left by Git
| div.related{ | ||
| color:rgba(255,255,255,0.7); /* classic overwrite */ | ||
| border-color:#424242; | ||
| <<<<<<< HEAD |
Uh oh!
There was an error while loading. Please reload this page.
ONKARBH commented Jan 20, 2025
"Thank you for your valuable time and feedback! I've addressed the accidental code left by Git, deleted the unnecessary lines as per your suggestion, and ensured everything aligns with the intended structure. I appreciate your guidance and look forward to your approval for the final merge." |
AA-Turner commented Jan 20, 2025
@ONKARBH have you used a generative AI tool such as ChatGPT, Claude, or similar to create this PR? If so, can you guarantee that the contribution is your own work and abides by the licence? A |
AA-Turner left a comment
AA-Turner left a comment There was a problem hiding this comment.
I'm minded to close this PR. If you'd still like to contribute, please first read our policy on acceptable use of generative AI.
A
There was a problem hiding this comment.
Can you explain which of the changes in this file are relevant? As far as I can tell, they are all stylistic.
| @@ -1,178 +1,332 @@ | |||
| /* Common colours */ | |||
| /* Updated Common colors */ | |||
There was a problem hiding this comment.
This change isn't needed
| /* Updated Common colors */ | |
| /* Common colours*/ |
| --good-color:rgb(79,196,100); | ||
| --good-color:rgb(79196100); | ||
| --good-border:var(--good-color); | ||
| --middle-color:rgb(244,227,76); | ||
| --middle-border:var(--middle-color); | ||
| --bad-color:rgb(244,76,78); | ||
| --bad-border:var(--bad-color); |
There was a problem hiding this comment.
This duplicates --good-color and makes no other changes
3 participants
"Revamped the sidebar layout with a darker background and improved responsiveness. Introduced a transition effect for smooth resizing and visibility toggling. Added media queries to adjust sidebar width on various screen sizes and hide the sidebar on small screens, with a sidebar button for toggling. Enhanced hover effects and ensured the sidebar remains functional across devices."