Skip to content

Make sidebar width more flexible#218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 4 commits into from
Feb 4, 2025
Merged

Make sidebar width more flexible #218

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a13c64
Bump sidebar width to 260px
tomasr8 Feb 2, 2025
7430795
Use less specific selectors
tomasr8 Feb 3, 2025
dec0899
Make sidebar width more flexible
tomasr8 Feb 3, 2025
e36331f
Merge remote-tracking branch 'upstream/main' into sidebar-width
tomasr8 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions python_docs_theme/static/pydoctheme.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,6 +140,8 @@ span.pre{
}

div.sphinxsidebar{
display: flex;
Copy link
Member

@AA-TurnerAA-TurnerFeb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is flexbox required here?

Copy link
MemberAuthor

@tomasr8tomasr8Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows me to remove the hardcoded width: 217px; from div.sphinxsidebarwrapper

width: min(25vw, 350px);
float: none;
position: sticky;
top: 0;
Expand All@@ -156,13 +158,17 @@ div.sphinxsidebar h4{
margin-top: 1.5em;
}

div.bodywrapper{
margin-left: min(25vw, 350px);
}

div.sphinxsidebarwrapper{
width: 217px;
box-sizing: border-box;
height: 100%;
overflow-x: hidden;
overflow-y: auto;
float: left;
float: none;
flex-grow: 1;
}

div.sphinxsidebarwrapper > h3:first-child{
Expand DownExpand Up@@ -202,9 +208,10 @@ div.sphinxsidebar input[type='text']{
font-size: 1.2em;
cursor: pointer;
padding-top: 1px;
float: right;
float: none;
/* after Sphinx 4.x and earlier is dropped, only the below is needed */
width: 12px;
min-width: 12px;
border-radius: 0 5px 5px 0;
border-left: none;
}
Expand DownExpand Up@@ -485,7 +492,7 @@ div.genindex-jumpbox a{
margin-inline-end: 0;
}
/* Remove sidebar and top related bar */
div.related, .sphinxsidebar{
div.related, div.sphinxsidebar{
display: none;
}
/* Anchorlinks are not hidden by fixed-positioned navbar when scrolled to */
Expand Down
Loading