Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 75
Enable theme translation#246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
StanFromIreland commented Aug 7, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
rffontenelle commented Aug 7, 2025
Thanks for fixing what was missing with the solution! |
m-aciek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation improvement suggestions, otherwise looks good to me 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
m-aciek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for better portability
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right, but I'd appreciate a PR approval from a translator as well.
And we can always iterate and fix as needed after an initial release.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland commented Sep 2, 2025
Maciek has already reviewed translation, see above. |
Uh oh!
There was an error while loading. Please reload this page.
hugovk commented Sep 2, 2025
Yes, but not approved. |
StanFromIreland commented Sep 2, 2025
In hopes of getting this in faster, I can just delete it? Fun fact, translations of the Python docs are actually not reviewed for most languages. |
StanFromIreland commented Sep 2, 2025
Preview! (built with |
m-aciek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland commented Sep 3, 2025
It is no longer a follow up, it is now included in this PR! Verified manually that the artefact has the compiled files. |
rffontenelle commented Sep 3, 2025
Sweet! Was setup-python really necessary, considering that python is already included in the GH runner image? |
StanFromIreland commented Sep 3, 2025
It is used in all other workflows in this repository when Python is needed. |
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
4f43ade into python:mainUh oh!
There was an error while loading. Please reload this page.
Adds Polish to start. Based on @rffontenelle 's pr. This does not allow for translation of the Copy button for some reason, but I think that can be left for another time.
Result:
📚 Documentation preview 📚: https://python-docs-theme-previews--246.org.readthedocs.build/
🇵🇱 Polish preview 🇵🇱