Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Sep 9, 2025

There two issues, firstly some languages were not compiled and therefore don't load (e.g. Polish), and secondly, we hijacked the gettext for html files with python-docs-theme.po, resulting in messages in sphinx.po not loading (e.g. Greek).

Complete preview, built with translations: https://stan.ulbrych.org/preview/theme-translation/ (vs. current docs)

Compilation issue

We now get:

compiling catalog python_docs_theme/locale/zh_TW/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/zh_TW/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/tr/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/tr/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/pt_BR/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/pt_BR/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/sv/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/sv/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/pl/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/pl/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/ja/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/ja/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/zh_CN/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/zh_CN/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/es/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/es/LC_MESSAGES/python-docs-theme.mo compiling catalog python_docs_theme/locale/el/LC_MESSAGES/python-docs-theme.po to python_docs_theme/locale/el/LC_MESSAGES/python-docs-theme.mo 

📚 Documentation preview 📚: https://python-docs-theme-previews--263.org.readthedocs.build/

@StanFromIrelandStanFromIreland mentioned this pull request Sep 9, 2025
4 tasks
Copy link
Contributor

@rffontenellerffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland
Copy link
MemberAuthor

Added type hints per documentation.

@hugovkhugovk merged commit fee2ae0 into python:mainSep 15, 2025
12 checks passed
@StanFromIrelandStanFromIreland deleted the fix-translation branch September 15, 2025 16:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland@hugovk@rffontenelle@m-aciek