Improve favicons to match www.python.org#56
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The Python favicons on https://docs.python.org (and https://pip.pypa.io etc.) are much lower resolution than on https://www.python.org
Here they are, docs on the left, www on the right, on a Mac Retina screen:
The first commit here (5088726) adds
favicon.icofrom https://github.com/python/pythondotorg/tree/master/static/favicon.ico (containing 16x16, 32x32 and icons) and uses it for the basic favicon instead of the low-resolution 16x16pxpy.png.The second (1b2f0e0) add the Apple touch icons and Microsoft Win8 tile icons, also from https://github.com/python/pythondotorg/tree/master/static, and shows them with the same markup as www.python.org:
https://github.com/python/pythondotorg/blob/65cb6aa6e9f2e2f87195e1997cfe74d32701c0be/templates/base.html#L41-L52
Finally, the third (471c170) copies the 57x57px
apple-touch-icon-precomposed.png(the smallest new one) on top of the low-res 16x16pxpy.pngwhich is shown inline in the header/footer breadcrumbs, and shows it also at 16x16px.(So
apple-touch-icon-precomposed.pngandpy.pngare duplicates. Would it better to use a single filename for both? If so, what?)Before
After