Skip to content

Conversation

@zmwangx
Copy link
Contributor

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme (see commit sphinx-doc/sphinx@b345acc), leaving pre elements uncolored.

Without the fix:

Screen Shot 2020-10-10 at 11 14 05 AM

Should be:

Screen Shot 2020-10-10 at 11 15 19 AM

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme[1], leaving pre elements uncolored. [1] sphinx-doc/sphinx@b345acc
zmwangx added a commit to zmwangx/dim that referenced this pull request Oct 10, 2020
@zmwangx
Copy link
ContributorAuthor

Wait, was this change intentional? Just noticed that Python 3.10 docs, rendered with Sphinx 3.2.1, features background color-less code blocks.

In any case I certainly prefer the old style.

@JulienPalard
Copy link
Member

JulienPalard commented Oct 10, 2020

Looks related to sphinx-doc/sphinx#7720 / sphinx-doc/sphinx#7721

@zmwangx
Copy link
ContributorAuthor

@corona10
Copy link
Member

@pablogsalpablogsal merged commit e77bd1a into python:masterDec 19, 2020
@pablogsal
Copy link
Member

pablogsal commented Dec 19, 2020

@Mariatta Do you happen to know who has privileges to publish a new version to pypi? We need a new version to restore the colourized backgrounds.

@Mariatta
Copy link
Member

I can publish this later this evening.

@zmwangxzmwangx deleted the codebgcolor-codetextcolor branch December 21, 2020 05:27
@Mariatta
Copy link
Member

We've released v 2020.12
On PyPI: https://pypi.org/project/python-docs-theme/2020.12/
Changelog https://github.com/python/python-docs-theme/releases/tag/v2020.12

@pablogsal
Copy link
Member

Thanks a lot @Mariatta!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@zmwangx@JulienPalard@corona10@pablogsal@Mariatta@the-knights-who-say-ni