Skip to content

Conversation

@mhsmith
Copy link
Member

@mhsmithmhsmith commented Jul 30, 2025

See the linked issue for details:

Since there will be no Android releases for Python 3.13 and earlier, the Android release job is skipped on those versions. See the "Temporarily point inputs ..." commit for a run that includes Android.

The lint and docs failures appear to be unrelated.

@mhsmithmhsmith marked this pull request as ready for review July 30, 2025 16:30
@mhsmithmhsmith requested a review from hugovkJuly 30, 2025 16:31
Copy link

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the current state of python/cpython#137186, this makes sense to me

@hugovk
Copy link
Member

(Updated from main to fix mypy.)

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set the defaults to a 3.14 commit, so we test Android for regular PRs and don't break it by mistake:

# Set from inputs for workflow_dispatch, or set defaults to test push/PR eventsenv: GIT_REMOTE: ${{github.event.inputs.git_remote || 'python' }}GIT_COMMIT: ${{github.event.inputs.git_commit || '48f88310044c6ef877f3b0761cf7afece2f8fb3a' }}CPYTHON_RELEASE: ${{github.event.inputs.cpython_release || '3.14.0rc1' }}

@hugovkhugovk marked this pull request as draft August 4, 2025 09:18
@mhsmith
Copy link
MemberAuthor

mhsmith commented Aug 4, 2025

Let's set the defaults to a 3.14 commit, so we test Android for regular PRs and don't break it by mistake

I agree, but that'll have to wait until there's a tag that includes the Android build action from python/cpython#137186.

@mhsmithmhsmith changed the title Add Android release jobAdd Android supportAug 6, 2025
@mhsmith
Copy link
MemberAuthor

mhsmith commented Aug 9, 2025

python/cpython#137186 has been changed to use an android.py ci command rather than a composite action, so I've updated this PR to match. Once again, I've tested an Android run by pointing it at my own repository (in the actions of the "Update type annotations" commit), and then reverted to the previous inputs.

@mhsmith
Copy link
MemberAuthor

I've updated run_release.py to include Android, and tested the relevant functions using my own SSH server. Because the Android binaries are now released via the same mechanism as the source tarballs, the temporary directory has been renamed from src to downloads.

I've also created python/peps#4541 to make the corresponding changes to PEP 101.

Pending the merge of python/cpython#137186, I think this PR is now complete.

@mhsmithmhsmith requested a review from hugovkAugust 12, 2025 21:01
@mhsmithmhsmith marked this pull request as ready for review August 12, 2025 21:01
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

select_jobs.py Outdated
Comment on lines 21 to 22
# Android binary releases began in Python 3.14.
output("android", version.release>= (3, 14))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess technically they'll start in rc2 or rc3, but practically speaking I'm never going to do 3.14.0rc1 again :) And this much simplifies the logic.)

mhsmithand others added 3 commits August 13, 2025 12:30
@hugovkhugovk merged commit ee55b01 into python:masterAug 13, 2025
13 checks passed
@mhsmithmhsmith mentioned this pull request Aug 13, 2025
@hugovk
Copy link
Member

@mhsmith The candidate of release candidate 2 is now building Android, in case you want to check it:

https://github.com/python/release-tools/actions/runs/16965004771

@mhsmith
Copy link
MemberAuthor

Looks good to me!

webknjaz added a commit to webknjaz/python--release-tools that referenced this pull request Aug 14, 2025
This is a follow up for python#265 that added initial implementation with copy-pasted steps.
webknjaz added a commit to webknjaz/python--release-tools that referenced this pull request Aug 14, 2025
This is a follow up for python#265 that added initial implementation with copy-pasted steps.
webknjaz added a commit to webknjaz/python--release-tools that referenced this pull request Aug 14, 2025
This is a follow up for python#265 that added initial implementation with copy-pasted steps.
@TheDevilsNtheJenny
Copy link

I just started python and paid for the lifetime membership, but im only on the second course/step and im so lost i have no idea what im supposed to download or what im supposed to download it on, my phone? My chromebook ? Ugh please help

@webknjaz
Copy link
Member

@TheDevilsNtheJenny you probably need to start at https://docs.python.org/3/tutorial/index.html and perhaps ask for help at https://discuss.python.org/c/help/7.
Whatever course you purchased, they will probably also be able to help you as this place has no affiliation with it.
This bug tracker, though, is not a good place for asking such questions. Bear in mind that disruptive activity may get you banned and you're expected to follow the CoC.
Cheers!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mhsmith@hugovk@TheDevilsNtheJenny@webknjaz@freakboy3742@AA-Turner