Don't install types-* dependencies in pyright tests#10120
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Avasam changed the title types-* dependencies in pyright tests
Member
How about #10121, as an alternative fix? Feels a bit cleaner imo |
Member
AlexWaygood commented May 1, 2023
Superseded by #10121 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One idea to fix#10112 .
This idea could probably be extended to pytype and mypy stubs type-checking tests to reduce dependencies installs. (rename
requirements-pyright.txttorequirements-stubs-typecheck.txtor something)Or I can go the route of using
grepin CI to only include the dependencies needed to runget_external_stub_requirements.py, whilst keeping the version requirement.Or I can try to use grep to filter out
types-*dependencies.