Skip to content

Update typing-extensions; some 3.12 updates#10200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 26 commits into from
May 24, 2023
Merged

Update typing-extensions; some 3.12 updates #10200

JelleZijlstra merged 26 commits into from
May 24, 2023

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented May 23, 2023

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented May 23, 2023

@rchen152 could you take a look at the failure in https://github.com/python/typeshed/actions/runs/5052177791/jobs/9064782798?pr=10200 ? Feels like it has something to do with from typing import TypeVar as _TypeVar.

@JelleZijlstraJelleZijlstra mentioned this pull request May 23, 2023
Merged
@JelleZijlstra
Copy link
MemberAuthor

JelleZijlstra commented May 23, 2023

Split out the AST changes into #10201, as they're independent from the rest of the changes and less urgent to get in.

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed May 23, 2023
View reviewed changes
AlexWaygood
AlexWaygood previously approved these changes May 23, 2023
View reviewed changes
@AlexWaygoodAlexWaygood dismissed their stale reviewMay 23, 2023 13:20

collections.abc.Buffer.buffer should be abstract

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed May 23, 2023
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed May 23, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actionsbot commented May 24, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstraJelleZijlstra merged commit e4dcfcc into python:mainMay 24, 2023
@JelleZijlstraJelleZijlstra deleted the newte branch May 24, 2023 18:06
@JelleZijlstraJelleZijlstra restored the newte branch September 10, 2024 23:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@AlexWaygood