Skip to content

Conversation

@sobolevn
Copy link
Member

@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member

Oh, stubtest is failing for the one in the global scope. Can't immediately see why, though.

@sobolevn
Copy link
MemberAuthor

Because turtle uses some magic in _make_global_funcs, I am trying to figure out if this is correct.

@sobolevn
Copy link
MemberAuthor

I find missing default and kw-only translated into positional-or-keyword as problems. I will report a bug to cpython.

@AlexWaygood
Copy link
Member

Why don't you revert the global-namespace teleport changes for now, until the CPython change is fixed? Then we can merge this now, and deal with the last remaining change later

@sobolevn
Copy link
MemberAuthor

Sure!

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygoodAlexWaygood merged commit 19ed22e into mainAug 10, 2023
@AlexWaygoodAlexWaygood deleted the py312-turtle branch August 10, 2023 10:44
@AlexWaygood
Copy link
Member

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@AlexWaygood