Skip to content

Conversation

@edgarrmondragon
Copy link
Contributor

@edgarrmondragonedgarrmondragon commented May 6, 2025

@JelleZijlstra
Copy link
Member

Our policy is generally to not add features for new Python versions until the first beta, but that's tomorrow so I think it's fine to get this in.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment on lines 720 to 721
suggest_on_error: bool = ...,
color: bool = ...,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
suggest_on_error: bool=...,
color: bool=...,
suggest_on_error: bool=False,
color: bool=False,

I think we didn't fill in defaults here because at runtime they go through **kwargs. Let's add defaults for the new parameters at least, and if you like we can add defaults for the rest at some point too.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer if I add the missing defaults in this PR or in a separate one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in another PR, I'll merge this one

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstraJelleZijlstra merged commit 3f8a48f into python:mainMay 12, 2025
64 checks passed
@edgarrmondragonedgarrmondragon deleted the 3.14-argparse-parameters branch May 12, 2025 18:56
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
…ython#13947) These are - `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302 - `color`, added by python/cpython#132323 Co-authored-by: Sebastian Rittau <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@edgarrmondragon@JelleZijlstra@srittau