Skip to content

Conversation

@guoci
Copy link
Contributor

@srittau
Copy link
Collaborator

As far as I can see, this class was only added in 3.14 "for real". So we need to distinguish between those cases.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@guoci
Copy link
ContributorAuthor

I need help with resolving the remaining errors

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@guoci
Copy link
ContributorAuthor

It appears that the attribute name type is causing the error. If I rename it to _type_, it works fine.
See: #15057

@srittau
Copy link
Collaborator

I think it's best to have to complete separate _CField classes, one for 3.14+ and one for < 3.14. This way we can keep the @type_check_only decorator and it could alleviate some of the problems.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@guoci@srittau