filecmp and tempfile can handle pathlib.Path#2267
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Hmm, I think this may need to be split into Do the maintainers concur? The other option per https://github.com/python/typeshed/blob/master/CONTRIBUTING.md#stub-versioning would be to use |
gvanrossum commented Jun 20, 2018
I would use |
scivision changed the title filecmp and tempfile can handle pathlib.Pathscivision changed the title filecmp and tempfile can handle pathlib.Pathscivision commented Jun 21, 2018
OK I believe the fixes are ready to go. |
| ifsys.version_info>= (3, 6): | ||
| defcmp(f1: Union[bytes, Text, os.PathLike], f2: Union[bytes, Text, os.PathLike], | ||
| shallow: Union[int, bool] = ...) ->bool: ... | ||
| defcmpfiles(a: Union[AnyStr, os.PathLike], b: Union[AnyStr, os.PathLike], common: Iterable[Union[AnyStr, os.PathLike]], |
There was a problem hiding this comment.
Because this uses AnyStr, we should ideally also use a type variable in the PathLike case (so PathLike[AnyStr]). But this sort of things tends to run into mypy bugs sometimes. We should check a few cases like these:
cmpfiles(bytes, bytes)returnsTuple[List[bytes], ...]cmpfiles(str, str)returnsTuple[List[str], ...]cmpfiles(PathLike[str], PathLike[str])returnsTuple[List[str], ...]cmpfiles(PathLike[str], bytes)is an error
You can check these in mypy by using reveal_type.
| hide: Optional[Sequence[AnyStr]] = ...) ->None: ... | ||
| ifsys.version_info>= (3, 6): | ||
| def__init__(self, a: Union[AnyStr, os.PathLike], b: Union[AnyStr, os.PathLike], |
There was a problem hiding this comment.
Same here, we should use PathLike[AnyStr] but should verify it actually works.
Also, do the ignore and hide parameters also accept paths?
| defgettempprefixb() ->bytes: ... | ||
| ifsys.version_info>= (3, 6): | ||
| defTemporaryFile( |
There was a problem hiding this comment.
Most of these functions have the same issue with AnyStr.
srittau commented Oct 21, 2018
@scivision Are you still interested in this pull request? |
scivision commented Oct 31, 2018
Hi @srittau it seems like the fix grew bigger. I don't have much time lately so I have just been using |
srittau commented Nov 19, 2018
Thank you for your work on this. I am closing this PR for now. Please reopen it or open a new PR if you wish to finish it. |
4 participants
filecmpcan handlepathlib.Path, including:Before this patch, doing something like
would work fine when executed, but would give
mypyerrors likeAfter this change, type checking works as expected