Add many missing __match_args__ attributes#7556
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
AlexWaygood commented Mar 26, 2022
I guess I'll be right back with a flake8-pyi patch, then... |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jelle Zijlstra <[email protected]>
This comment has been minimized.
This comment has been minimized.
AlexWaygood commented Mar 26, 2022
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
MemberAuthor
AlexWaygood commented Mar 26, 2022
flake8-pyi PR here: PyCQA/flake8-pyi#192 |
JelleZijlstra approved these changes Mar 26, 2022
Contributor
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
MemberAuthor
AlexWaygood commented Mar 26, 2022
Many thanks for the reviews and flake8-pyi bugfix @JelleZijlstra! |
AlexWaygood added a commit to AlexWaygood/mypy that referenced this pull request Mar 26, 2022
python#12415 (included in release 0.942) unblocked typeshed from adding missing `__match_args__` attributes (see python/typeshed#7556). This means stubtest is now unblocked from checking the correctness of `__match_args__` attributes in the stub!
JelleZijlstra pushed a commit to python/mypy that referenced this pull request Mar 27, 2022
#12415 (included in release 0.942) unblocked typeshed from adding missing `__match_args__` attributes (see python/typeshed#7556). This means stubtest is now unblocked from checking the correctness of `__match_args__` attributes in the stub!
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although stubtest doesn't (yet) complain if
__match_args__is missing from the stub, it does complain if__match_args__is present but incorrect in the stub, so the CI should be fairly reliable here :)