Use re-exports instead of TypeAliases in several places#7634
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| fromtyping_extensionsimportTypeAlias | ||
| fromurllib3import_collections | ||
| fromurllib3._collectionsimportRecentlyUsedContainer |
There was a problem hiding this comment.
| fromurllib3._collectionsimportRecentlyUsedContainer | |
| fromurllib3._collectionsimportRecentlyUsedContainerasRecentlyUsedContainer |
There was a problem hiding this comment.
I did that initially, but stubtest called me out. Turns out that it doesn't actually exist at runtime, we just use it for annotations in the stub. Not sure why stubtest didn't flag it before now.
Source: https://github.com/psf/requests/blob/main/requests/sessions.py
Stubtest: https://github.com/python/typeshed/runs/6046468647?check_suite_focus=true
There was a problem hiding this comment.
Oh interesting. stubtest's checking of type aliases is a little loose, see https://github.com/python/mypy/blob/ce858a6a0c85206ff877faf702293a9b67fae750/mypy/stubtest.py#L960 (I don't quite remember why I did it this way, maybe worth reinvestigating)
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Fixes#7632