Skip to content

Conversation

@Avasam
Copy link
Collaborator

@AvasamAvasam commented Jan 14, 2023

Can't reference fontools directly because it does not have a py.typed marker (it's only partially typed).
It would be a bit overkill anyway.

Fixes an Any subclassing error in fpdf2 by shimming the needed fontools types.

Ref: #9491

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AvasamAvasam mentioned this pull request Feb 1, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam
Copy link
CollaboratorAuthor

Avasam commented Feb 8, 2023

Unlike in #9525, all type definitions here are subclasses of each-other. And parameters use standard types. So the whole shim file makes more sense for the full BasePen structure.

@srittausrittau merged commit 10086c0 into python:mainFeb 9, 2023
@AvasamAvasam deleted the fonttools-in-fpdf2 branch February 9, 2023 14:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasam@srittau