Remove a default value in distutils#9800
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes#9799. Stubtest started failing on our `setuptools` stubs because of a default value added to our stdlib `distutils` stubs. The reason for this is because our `setuptools` stubs erroneously claim here that the `setuptools._distutils.core.Distribution` class is the same as the stdlib `distutils.dist.Distribution` class: https://github.com/python/typeshed/blob/06755e10ba0d39e7e4c18fcc2663d9da564a71ad/stubs/setuptools/setuptools/_distutils/core.pyi#L3 In actual fact, they're not, and they have different default values for this parameter. But reverting the addition of the default value is the simplest short-term fix for now. (An alternative fix would be to just merge #9795.)
Contributor
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
MemberAuthor
AlexWaygood commented Feb 23, 2023
Merging so the "stubtest failed" bot doesn't create a duplicate issue in a few hours |
AlexWaygood added a commit to AlexWaygood/stubdefaulter that referenced this pull request Feb 23, 2023
JelleZijlstra pushed a commit to JelleZijlstra/stubdefaulter that referenced this pull request Feb 23, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9799.
Stubtest started failing on our
setuptoolsstubs because of a default value added to our stdlibdistutilsstubs. The reason for this is because oursetuptoolsstubs erroneously claim here that thesetuptools._distutils.core.Distributionclass is the same as the stdlibdistutils.dist.Distributionclass:typeshed/stubs/setuptools/setuptools/_distutils/core.pyi
Line 3 in 06755e1
In actual fact, they're not, and they have different default values for this parameter. But reverting the addition of the default value is the simplest short-term fix for now.
(An alternative fix would be to just merge #9795.)