Prepend bases on first subscription#386
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#385
Fixes#384
In previous versions of typing,
__bases__on subscription where prepend with__origin__, so that MRO of, e.g.,Mapping[int, T][str]was:This was removed for several reasons. However, now it looks like complete removal of such prepending was too radical, since now e.g.
issublcass(Node[int], Node)returnsFalse. I believe such runtime check should be equivalent toissublcass(Node, Node), i.e.,True.Here I propose to fix this by only prepending
__bases__on first subscription, so that, e.g,Mapping[int, T][str].__mro__will be:This PR also fixes an ambiguity when using
typingABCs withsingledispatch().