Skip to content

Add a backport of generic NamedTuples#44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 21 commits into from
May 26, 2022
Merged

Add a backport of generic NamedTuples #44

JelleZijlstra merged 21 commits into from
May 26, 2022

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented May 20, 2022•
edited
Loading

This PR backports the ability, added in python/cpython#92027, to define generic NamedTuple classes. The implementation and the tests are very similar to the implementation on the CPython main branch, with a few tweaks so that it all works on earlier versions of Python as well.

#7

@AlexWaygoodAlexWaygood marked this pull request as ready for review May 20, 2022 19:48
AlexWaygood
AlexWaygood commented May 20, 2022
View reviewed changes
@AlexWaygood
Copy link
MemberAuthor

AlexWaygood commented May 20, 2022

I think this is now ready for review!

srittau
srittau reviewed May 21, 2022
View reviewed changes
Copy link
Collaborator

@srittausrittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really claim to know what's going in this code, but everything seems reasonable and makes sense to me, but I have a few small remarks.

JelleZijlstra
JelleZijlstra reviewed May 21, 2022
View reviewed changes
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few small comments.

AlexWaygood
AlexWaygood commented May 21, 2022
View reviewed changes
JelleZijlstra
JelleZijlstra reviewed May 21, 2022
View reviewed changes
@AlexWaygood@JelleZijlstra
I can spell
2d36658
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstraJelleZijlstra merged commit 7c28357 into python:mainMay 26, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 26, 2022

Thank you!

@AlexWaygoodAlexWaygood deleted the namedtuple branch May 26, 2022 04:48
@AlexWaygood
Copy link
MemberAuthor

AlexWaygood commented May 26, 2022

Thank you! Super excited to see this happen :D

@AlexWaygoodAlexWaygood mentioned this pull request May 27, 2022
Merged
This was referenced Aug 12, 2024
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittausrittausrittau approved these changes

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@JelleZijlstra@srittau