Skip to content

Conversation

@JanEricNitschke
Copy link
Contributor

@JanEricNitschkeJanEricNitschke commented Sep 11, 2025

@JelleZijlstra
Copy link
Member

Thanks! Could you add a changelog entry and address the CI failures?

@JanEricNitschke
Copy link
ContributorAuthor

With the test failure in 3.13 there is actually a decision that would have to be made that i only noticed now.

Because 3.14 added os.PathLike to the allowlist. The question would be if we want to backport that as well? Then we would have to change this to 3.14 (i would dig up the breakpoint). Or i can just leave that and remove the PathLike support for now and just include the AsyncIterator one?

But i guess it makes the most sense to also backport the os.PathLike, so ill adjust the PR unless you disagree or think this needs more discussion.

@codecov
Copy link

codecovbot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.37%. Comparing base (9215c95) to head (03426a5).

@@ Coverage Diff @@## main #676 +/- ## ======================================= Coverage 97.36% 97.37% ======================================= Files 3 3 Lines 7680 7685 +5 ======================================= + Hits 7478 7483 +5  Misses 202 202 
FlagCoverage Δ
3.10?
3.10.489.00% <100.00%> (+<0.01%)⬆️
3.11.087.46% <100.00%> (+<0.01%)⬆️
3.12?
3.12.088.17% <100.00%> (+<0.01%)⬆️
3.1383.62% <100.00%> (?)
3.13.083.62% <100.00%> (+1.23%)⬆️
3.1478.85% <100.00%> (+0.01%)⬆️
3.989.71% <100.00%> (+<0.01%)⬆️
3.9.1289.71% <100.00%> (+<0.01%)⬆️
pypy3.1088.83% <100.00%> (+<0.01%)⬆️
pypy3.1188.09% <100.00%> (+<0.01%)⬆️
pypy3.989.54% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
src/test_typing_extensions.py98.39% <100.00%> (+<0.01%)⬆️
src/typing_extensions.py93.88% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JelleZijlstra
Copy link
Member

Yes, we should backport the PathLike support to 3.14 and adjust the version check accordingly.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@JanEricNitschke@JelleZijlstra