Skip to content

Conversation

@JanEricNitschke
Copy link
Contributor

Discovered through CPython 3.14 test_typing.py: https://github.com/JanEricNitschke/typing_extensions/actions/runs/17619859892/job/50062609198#step:7:44

Tests and code are directly taken from CPython 3.14.

Tests: https://github.com/python/cpython/blob/3.14/Lib/test/test_typing.py#L8616

Code: https://github.com/python/cpython/blob/3.14/Lib/typing.py#L3139

Except that i omitted the raising of the TypeError when overwriting a mutable key with a read-only key pending further discussion.

@codecov
Copy link

codecovbot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (9215c95) to head (bbf9dff).

@@ Coverage Diff @@## main #677 +/- ## ========================================== + Coverage 97.36% 97.38% +0.01%  ========================================== Files 3 3 Lines 7680 7716 +36 ========================================== + Hits 7478 7514 +36  Misses 202 202 
FlagCoverage Δ
3.1089.04% <100.00%> (+0.05%)⬆️
3.10.489.04% <100.00%> (+0.05%)⬆️
3.1188.28% <100.00%> (?)
3.11.087.51% <100.00%> (+0.05%)⬆️
3.1288.23% <100.00%> (+0.05%)⬆️
3.12.088.21% <100.00%> (+0.05%)⬆️
3.1382.47% <100.00%> (?)
3.13.082.47% <100.00%> (+0.08%)⬆️
3.1478.91% <100.00%> (+0.07%)⬆️
3.989.75% <100.00%> (+0.04%)⬆️
3.9.1289.75% <100.00%> (+0.04%)⬆️
pypy3.1088.88% <100.00%> (+0.05%)⬆️
pypy3.1188.14% <100.00%> (+0.05%)⬆️
pypy3.989.59% <100.00%> (+0.04%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
src/test_typing_extensions.py98.40% <100.00%> (+<0.01%)⬆️
src/typing_extensions.py93.91% <100.00%> (+0.02%)⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JanEricNitschke
Copy link
ContributorAuthor

This should also fix #308

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@JanEricNitschke