Skip to content

Conversation

@lostmsu
Copy link
Member

What does this implement/fix? Explain your changes.

The TypeBuilder.CreateType() polyfill was incorrectly returning typeof(TypeBuilder) instead of the new type created using TypeBuilder.

Does this close any currently open issues?

#1228

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #1261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #1261 +/- ## ======================================= Coverage 86.25% 86.25% ======================================= Files 1 1 Lines 291 291 ======================================= Hits 251 251 Misses 40 40 
FlagCoverage Δ
#setup_linux64.94% <ø> (ø)
#setup_windows72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db30b87...012288d. Read the comment docs.

@filmorfilmor merged commit f506d65 into pythonnet:masterOct 13, 2020
lostmsu added a commit to losttech/pythonnet that referenced this pull request Oct 13, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lostmsu@codecov-io@filmor