Add handling of asyncio coroutines.#162
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
astrojuanlu requested changes Oct 25, 2017
Collaborator
astrojuanlu left a comment
astrojuanlu left a comment There was a problem hiding this comment.
Hi! We just made some infrastructure changes that conflict with your PR. Would you mind rebasing and trying again? Also, adding some tests would be nice :)
| from distutils.core import setup | ||
| import setuptools | ||
| import memory_profiler |
Collaborator
There was a problem hiding this comment.
The method to extract the version was changed.
| license='BSD' | ||
| license='BSD', | ||
| install_requires=['asyncio>=3.4.3'] if sys.version_info < (3, 4) else [], |
Collaborator
There was a problem hiding this comment.
What about using PEP 426 markers instead? https://blog.ionelmc.ro/presentations/packaging/#slide:25
OleksaVasylenko commented Sep 21, 2018
@apollovy Hi! Are you going to finish that? That would be a great benefit. |
Author
apollovy commented Sep 21, 2018 via email
Hi. I believe not in the nearest future at least: no time or any plans about it. It just works for me, so I'm using it from my fork and that's it. пт, 21 сент. 2018 г., 14:12 Oleksa Vasylenko <[email protected]>: …@apollovy <https://github.com/apollovy> Hi! Are you going to finish that? That would be a great benefit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABmCLyL6lszyFJWj6pMPYwqKCb1Sfn1xks5udMmLgaJpZM4PpAME> . |
Collaborator
astrojuanlu commented Sep 27, 2018
@OleksaVasylenko if you want to take over, you could do like this on a local memory_profiler checkout: and we can continue the review from there. Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
This patch works for current versions of python, but breaks <3.3 where
yield fromis a syntax error and returning from generatior is not allowed.I will just leave it here in case somebody would want to use this project in async world.
By now I don't see an easy way to deal with the situation except that making a dependency from tornado in 2.7 (and maybe 2.6) and use their machinery for coroutines. But by now I doubt it's worth spending a time on it 🤗
Fixes#161