[feat] Support 1D topk#1491
Merged
[feat] Support 1D topk #1491
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
# Description The TensorRT topk layer requires at least 2 dimensions in the input tensor. Previously you would see this error for 1D inputs: `ERROR: [Torch-TensorRT TorchScript Conversion Context] - 3: (Unnamed Layer* 74) [TopK]: at least 2 dimensions are required for input.` This PR adds an unsqueeze for the inputs and corresponding squeeze for the outputs to workaround this limitation. Fixes # (issue) ## Type of change Please delete options that are not relevant and/or add your own. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update # Checklist: - [ ] My code follows the style guidelines of this project (You can use the linters) - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas and hacks - [ ] I have made corresponding changes to the documentation - [ ] I have added tests to verify my fix or my feature - [ ] New and existing unit tests pass locally with my changes - [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified
github-actionsbot added component: conversion 
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TensorRT topk layer requires at least 2 dimensions in the input tensor. Previously you would see this error for 1D inputs:
ERROR: [Torch-TensorRT TorchScript Conversion Context] - 3: (Unnamed Layer* 74) [TopK]: at least 2 dimensions are required for input.This PR adds an unsqueeze for the inputs and corresponding squeeze for the outputs to workaround this limitation.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: