feat: Upgrade Docker build to use custom TRT + CUDNN#1805
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Upgrade Ubuntu version to 22.04 - Make custom build args for TensorRT and CUDNN versions, user-specifiable in a.b.c version format - Make build args required, without defaults, to improve code cleanliness and reduce amount of changes needed when versions shift - Provide clear error messages when the build args are not provided by the user - Add documentation of the change in the Docker README
gs-olive added WIP 
gs-olive commented Apr 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
gs-olive commented Apr 7, 2023
docker/Dockerfile Outdated
| RUN cp ./docker/WORKSPACE.docker WORKSPACE | ||
| # Symlink the path pyenv is using for python with the /usr/local/lib/ for package sourcing | ||
| RUN ln -s "`pyenv which python | xargs dirname | xargs dirname`/lib/python$PYTHON_VERSION/site-packages""/usr/local/lib/python" |
ContributorAuthor
There was a problem hiding this comment.
Since pyenv puts the packages for the distribution in a different location, create a symbolic link to an unchanging path, which is then used in the WORKSPACE files to source libtorch.
gs-oliveforce-pushed the docker_improvements branch 2 times, most recently from bea8814 to 7b1707bCompare- Add support for pyenv in Docker file, allowing specification of a custom Python version - Update WORKSPACE files to automatically synchronize regardless of Python version choice, using symbolic links - Update dependencies accordingly - Add documentation for changing the base image of the Docker container
gs-oliveforce-pushed the docker_improvements branch from 7b1707b to a26438eCompare
- Add documentation regarding Python versioning
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#1782
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: