Skip to content

Conversation

@zewenli98
Copy link
Collaborator

Description

Since CUDNN is no longer required by Torch-TRT, remove CUDNN dependencies.

Fixes#2795

Type of change

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98zewenli98 self-assigned this May 1, 2024
@github-actionsgithub-actionsbot added documentation Improvements or additions to documentation component: core Issues re: The core compiler component: build system Issues re: Build system component: api [Python] Issues re: Python API labels May 1, 2024
@zewenli98zewenli98force-pushed the remove_cudnn_dependencies branch from 3fff8df to ca38612CompareMay 3, 2024 01:37
@github-actionsgithub-actionsbot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels May 6, 2024
Copy link
Collaborator

@peri044peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 36 to 40
RUN wget https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/cuda-ubuntu2204.pin
RUN mv cuda-ubuntu2204.pin /etc/apt/preferences.d/cuda-repository-pin-600
RUN apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/7fa2af80.pub
RUN add-apt-repository "deb https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/ /"
RUN apt-get update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part can be removed I think. Reference:

RUN pyenv global ${PYTHON_VERSION}
# Install TensorRT + dependencies
RUN apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/3bf863cc.pub
RUN add-apt-repository "deb https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/x86_64/ /"
RUN apt-get update
RUN apt-get install -y libnvinfer10=${TENSORRT_VERSION}.* libnvinfer-plugin10=${TENSORRT_VERSION}.* libnvinfer-dev=${TENSORRT_VERSION}.* libnvinfer-plugin-dev=${TENSORRT_VERSION}.* libnvonnxparsers10=${TENSORRT_VERSION}.* libnvonnxparsers-dev=${TENSORRT_VERSION}.*
# Setup Bazel via Bazelisk
RUN wget -q https://github.com/bazelbuild/bazelisk/releases/download/v1.17.0/bazelisk-linux-amd64 -O /usr/bin/bazel &&\

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave it like this. I've removed this as a part of #2793

### Instructions

- The example below uses CUDNN 8.9 and TensorRT 8.6
- The example below uses TensorRT 8.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI (you don't need to change here but I changed this to TRT 10 in my docker PR).

@zewenli98zewenli98 merged commit db67cb9 into mainMay 7, 2024
laikhtewari pushed a commit that referenced this pull request May 24, 2024
zewenli98 added a commit that referenced this pull request May 29, 2024
zewenli98 added a commit that referenced this pull request May 29, 2024
@zewenli98zewenli98 mentioned this pull request May 29, 2024
7 tasks
peri044 pushed a commit that referenced this pull request May 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signedcomponent: api [Python]Issues re: Python APIcomponent: build systemIssues re: Build systemcomponent: conversionIssues re: Conversion stagecomponent: convertersIssues re: Specific op converterscomponent: coreIssues re: The core compilercomponent: dynamoIssues relating to the `torch.compile` or `torch._dynamo.export` pathsdocumentationImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Remove CUDNN dependency in the documentation

4 participants

@zewenli98@peri044@facebook-github-bot