Swift 4.2 Migration#45
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nt from travis test due to some issue with Xcode 10 and cocoapods
Owner
radex commented Oct 14, 2018
LGTM @asowers1! Thanks for the PR. Would you mind adding a changelog entry? PS. I don't really maintain this repo anymore — I can give you GitHub and CocoaPods access if you want to take over |
This was referenced Oct 14, 2018
Closed
Closed
CollaboratorAuthor
asowers1 commented Oct 14, 2018
Sounds good to me! I can take care of that. |
CollaboratorAuthor
asowers1 commented Oct 15, 2018
@radex, the changelog is set. I can move ahead with the new tag and pod repo update whenever you're ready. |
Owner
radex commented Oct 16, 2018
@asowers1 Added you as GitHub collaborator and given you access to CocoaPods. Go ahead with pushing the changes. Feel free to update the readme to give yourself credit as the maintainer ;) |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does: