Skip to content

Fix casting of invalid time values#1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aidanharan merged 2 commits into from
Nov 8, 2024
Merged

Fix casting of invalid time values #1258

aidanharan merged 2 commits into from
Nov 8, 2024

Conversation

@aidanharan
Copy link
Contributor

@aidanharanaidanharan commented Nov 8, 2024•
edited
Loading

Fix the following test:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/11743718880/job/32717200431?pr=1257

 1) Failure: AttributeMethodsTest#test_0088_time zone-aware attributes do not recurse infinitely on invalid values [/usr/local/bundle/bundler/gems/rails-c694e575cf0f/activerecord/test/cases/attribute_methods_test.rb:933]: Expected: [] Actual: nil

Test introduced by rails/rails#53359

@aidanharanaidanharan marked this pull request as ready for review November 8, 2024 19:07
@aidanharanaidanharan merged commit 27c193c into mainNov 8, 2024
4 checks passed
@aidanharanaidanharan deleted the time-zone-aware-attrib branch November 8, 2024 19:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rails-8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidanharan