Skip to content

Commit 517f0d5

Browse files
committed
[bug] fix link add state not changing when using keybaord shortcuts
1 parent 848f236 commit 517f0d5

File tree

5 files changed

+58
-46
lines changed

5 files changed

+58
-46
lines changed

‎src/js/control.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ var control = (function(){
5858
element: helper.e(".control-link-add"),
5959
type: "button",
6060
func: function(){
61-
link.add();
61+
link.add.open();
6262
}
6363
},{
6464
element: helper.e(".control-link-edit"),

‎src/js/keyboard.js‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@ var keyboard = (function(){
1111
}elseif(state.get().menu){
1212
menu.close();
1313
shade.close();
14-
pagelock.unlock();
1514
}elseif(state.get().autoSuggest){
1615
autoSuggest.destroy();
16+
}elseif(state.get().link.add){
17+
link.add.close();
18+
shade.close();
1719
}elseif(state.get().modal){
1820
modal.close();
1921
shade.close();
20-
pagelock.unlock();
2122
}elseif(state.get().link.edit){
2223
helper.setObject({
2324
object: state.get(),
@@ -43,7 +44,7 @@ var keyboard = (function(){
4344
if(state.get().modal){
4445
modal.close();
4546
};
46-
link.add();
47+
link.add.open();
4748
};
4849
};
4950
},false);
@@ -65,7 +66,10 @@ var keyboard = (function(){
6566
window.addEventListener("keydown",function(event){
6667
// ctrl+alt+m
6768
if(event.ctrlKey&&event.altKey&&event.keyCode==77){
68-
if(state.get().modal){
69+
if(state.get().link.add){
70+
link.add.close();
71+
shade.close();
72+
}elseif(state.get().modal){
6973
modal.close();
7074
shade.close();
7175
};

‎src/js/link.js‎

Lines changed: 47 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -727,45 +727,53 @@ var link = (function(){
727727
helper.e(".link-form-text-icon").focus();
728728
};
729729

730-
varadd=function(){
731-
mod.add.open();
732-
stagedLink.init();
733-
modal.open({
734-
heading: "Add a new bookmark",
735-
successAction: function(){
736-
stagedLink.data.timeStamp=newDate().getTime();
737-
bookmarks.add(JSON.parse(JSON.stringify(stagedLink.data)));
738-
data.save();
739-
mod.add.close();
740-
render.clear();
741-
render.item.all();
742-
render.item.tabindex();
743-
sortable(".link-area");
744-
control.dependents();
745-
control.render();
746-
stagedLink.reset();
747-
shade.close();
748-
pagelock.unlock();
749-
},
750-
cancelAction: function(){
751-
mod.add.close();
752-
stagedLink.reset();
753-
autoSuggest.destroy();
754-
shade.close();
755-
pagelock.unlock();
756-
},
757-
actionText: "Add",
758-
size: "small",
759-
content: render.form()
760-
});
761-
shade.open({
762-
action: function(){
763-
mod.add.close();
764-
modal.close();
765-
pagelock.unlock();
766-
}
767-
});
768-
pagelock.lock();
730+
varadd={
731+
open: function(){
732+
mod.add.open();
733+
stagedLink.init();
734+
modal.open({
735+
heading: "Add a new bookmark",
736+
successAction: function(){
737+
stagedLink.data.timeStamp=newDate().getTime();
738+
bookmarks.add(JSON.parse(JSON.stringify(stagedLink.data)));
739+
data.save();
740+
mod.add.close();
741+
render.clear();
742+
render.item.all();
743+
render.item.tabindex();
744+
sortable(".link-area");
745+
control.dependents();
746+
control.render();
747+
stagedLink.reset();
748+
shade.close();
749+
pagelock.unlock();
750+
},
751+
cancelAction: function(){
752+
console.log("hit");
753+
mod.add.close();
754+
stagedLink.reset();
755+
autoSuggest.destroy();
756+
shade.close();
757+
pagelock.unlock();
758+
},
759+
actionText: "Add",
760+
size: "small",
761+
content: render.form()
762+
});
763+
shade.open({
764+
action: function(){
765+
mod.add.close();
766+
modal.close();
767+
pagelock.unlock();
768+
}
769+
});
770+
pagelock.lock();
771+
},
772+
close: function(){
773+
mod.add.close();
774+
modal.close();
775+
pagelock.unlock();
776+
}
769777
};
770778

771779
varedit=function(){

‎src/js/version.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
varversion=(function(){
22

3-
varcurrent="3.51.0";
3+
varcurrent="3.52.0";
44

55
varcompare=function(a,b){
66
varpa=a.split(".");

‎src/manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "nightTab",
33
"short_name": "nightTab",
44
"description": "A neutral new tab page accented with a chosen colour. Customise the layout, style, background and bookmarks in nightTab.",
5-
"version": "3.51.0",
5+
"version": "3.52.0",
66
"manifest_version": 2,
77
"chrome_url_overrides":{
88
"newtab": "index.html"

0 commit comments

Comments
(0)