Skip to content

template improvements#45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timelyportfolio merged 3 commits into from
Feb 16, 2021
Merged

template improvements #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08bfc98
change internal widget_html to `@noRd` #44
timelyportfolio Aug 1, 2020
b954fa0
remove duplicate `path` key from template webpack #44
timelyportfolio Aug 1, 2020
e3e91ff
remove unused `importFrom shiny restoreInput` in input template #44
timelyportfolio Aug 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion inst/templates/input_r.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
#'
#' <Add Description>
#'
#' @importFrom shiny restoreInput
#' @importFrom reactR createReactShinyInput
#' @importFrom htmltools htmlDependency tags
#'
Expand Down
1 change: 0 additions & 1 deletion inst/templates/webpack.config.js.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@ module.exports ={
mode: 'development',
entry: path.join(__dirname, 'srcjs', '${name}.jsx'),
output:{
path: path.join(__dirname, 'inst', 'www', '${package}', '${name}'),
path: path.join(__dirname, '${outputPath}'),
filename: '${name}.js'
},
Expand Down
2 changes: 1 addition & 1 deletion inst/templates/widget_r.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -50,7 +50,7 @@ render${capName} <- function(expr, env = parent.frame(), quoted = FALSE){
}

#' Called by HTMLWidgets to produce the widget's root element.
#' @rdname ${name}-shiny
#' @noRd
${name}_html <- function(id, style, class, ...){
htmltools::tagList(
# Necessary for RStudio viewer version < 1.2
Expand Down