Skip to content

Conversation

@Archmonger
Copy link
Contributor

@ArchmongerArchmonger commented Jan 12, 2025

Description

This PR plays around with the ReactPy-Router's internals to make custom routers possible.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@ArchmongerArchmonger marked this pull request as ready for review January 12, 2025 11:05
@ArchmongerArchmonger requested a review from a team as a code ownerJanuary 12, 2025 11:05
@ArchmongerArchmonger changed the title Custom router interfaceCustom router APIJan 12, 2025
@ArchmongerArchmonger merged commit 88ec72f into reactive-python:mainJan 12, 2025
12 checks passed
@ArchmongerArchmonger deleted the add-MatchedRoute-type branch January 12, 2025 11:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CompiledRoute.resolve to return a dataclass, not a tuple Create docs for "Creating a Custom Router"

1 participant

@Archmonger