Skip to content

Conversation

@ameetmadan
Copy link
Contributor

No description provided.

@ChrisB9
Copy link
Collaborator

Just as a hint: #26
Please change the text to 'du'

@ameetmadanameetmadan changed the title Update thinking-in-react.mdTranslate thinking-in-react.mdApr 25, 2023
@ameetmadanameetmadan marked this pull request as ready for review April 25, 2023 14:01
Copy link
Collaborator

@ChrisB9ChrisB9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through some of the changes already and got some suggestions

ameetmadanand others added 10 commits April 26, 2023 21:39
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
Co-authored-by: Christian Rodriguez Benthake <[email protected]>
@ameetmadan
Copy link
ContributorAuthor

Accepted your changes, did miss some of the things which should have been obvious. Thanks for reviewing!

@ameetmadanameetmadan requested a review from ChrisB9May 1, 2023 15:53
@ameetmadan
Copy link
ContributorAuthor

Is there anything left from my side to do?

@ChrisB9
Copy link
Collaborator

@ameetmadan thanks for the reminder, no everything looked good as far as i could say.

@github-actions
Copy link

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

PageSize (compressed)First Load
/40476.04 KB(🟢 -46 B)169.67 KB
/50076.03 KB(🟢 -46 B)169.66 KB
/[[...markdownPath]]77.46 KB(🟢 -46 B)171.08 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@ChrisB9ChrisB9 merged commit 75d898c into reactjs:mainMay 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ameetmadan@ChrisB9