[3.x] Support iterable type for parallel() + series() + waterfall()#45
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SimonFrings approved these changes Jun 13, 2022
WyriHaximus approved these changes Jun 13, 2022
Member
WyriHaximus left a comment
WyriHaximus left a comment There was a problem hiding this comment.
Nice! Also been eyeing this for react/promise and gave it a local shot. But glad to see you also filed reactphp/promise#225 👍
This was referenced Jun 13, 2022
clue changed the title parallel() + series() + waterfall()parallel() + series() + waterfall()Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for the
iterabletype forparallel()+series()+waterfall(). Instead of only accepting anarray, each function now also accepts instances implementingTraversablesuch asIteratorandGeneratorinstances.This is a pure feature addition that does not break BC. With these changes applied, our API is now in line with the other promise APIs (see reactphp/promise#225).
This PR targets Async v3 as the minimum API version. If this gets merged, I'll file a follow-up PR to apply the same changes also for Async v4.
The first commit highlights how this is essentially only a new type definition and a call to
iterator_to_array(). The second commit then takes advantage of a more iterative approach that uses less memory and also supports consuming infinite iterators if the resulting promise settles. The test suite confirms this has 100% code coverage.Refs #41
Builds on top of #11
Refs https://twitter.com/another_clue/status/1535652835521613824 (UML of iterators in PHP)