Skip to content

Conversation

@nhedger
Copy link
Contributor

Copy link
Member

@clueclue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thank you!

Can you apply/squash this minor suggestion? Once this is in, we should also apply the same changes to the 3.x and 2.x branches 👍

@clueclue added this to the v4.0.0 milestone Jun 20, 2022
@clueclue requested a review from WyriHaximusJune 20, 2022 14:53
Copy link
Member

@clueclue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for the quick update, changes LGTM! 👍

@WyriHaximusWyriHaximus merged commit 8f4251c into reactphp:4.xJun 24, 2022
@nhedgernhedger deleted the chore/remove-leading-dollar branch June 24, 2022 09:57
@clue
Copy link
Member

clue commented Jun 27, 2022

@nhedger Glad this has been merged! Can you also apply the same changes to the 3.x and 2.x branches? 👍

@nhedger
Copy link
ContributorAuthor

@clue, see #52 and #53

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nhedger@clue@WyriHaximus