Skip to content

Conversation

@WyriHaximus
Copy link
Member

The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here.

Refs: reactphp/promise#223

The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here. Refs: reactphp/promise#223
@WyriHaximusWyriHaximus added the bug Something isn't working label Jan 25, 2023
@WyriHaximusWyriHaximus added this to the v4.1.0 milestone Jan 25, 2023
Copy link
Member

@SimonFringsSimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clueclue added maintenance and removed bug Something isn't working labels Jan 25, 2023
@clueclue merged commit 7012b4c into reactphp:4.xJan 25, 2023
@WyriHaximusWyriHaximus deleted the 4.x-template-params-can-only-have-one-argument branch November 20, 2023 20:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@clue@SimonFrings