[3.x] Add PHPStan to test environment with max level#77
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SimonFrings approved these changes Jun 14, 2023
WyriHaximus approved these changes Jun 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 20, 2023
This was referenced Mar 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset backports #76 from
4.xto3.xto add PHPStan onmaxlevel to the test environment for all supported PHP versions. Most changes have been applied as-is, but v3 requires a number of workarounds to support legacy PHP and PHPUnit versions.If this PR is merged, we could backport most of the changes from v3 to v2. The changes are somewhat similar across all versions, but v2 still supports legacy PHP, so we would have to resort to type definitions in docblocks instead of native PHP types. Let's continue this discussion outside of this PR.
Builds on top of #76
See also https://github.com/orgs/reactphp/discussions/469