Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2#92
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximus approved these changes Jul 7, 2025
Member
WyriHaximus left a comment
WyriHaximus left a comment There was a problem hiding this comment.
Thanks for the extra bit of details; LGTM 
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus added a commit to WyriHaximus-labs/dns that referenced this pull request Jul 9, 2025
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #87, #81 and #76.