Describe current behavior on the cache interface#21
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsor reviewed Feb 3, 2018
src/CacheInterface.php Outdated
| { | ||
| // @return React\Promise\PromiseInterface | ||
| /** | ||
| * Retrieve an item from cache, resolves with its value on |
src/CacheInterface.php Outdated
| // @return React\Promise\PromiseInterface | ||
| /** | ||
| * Retrieve an item from cache, resolves with its value on | ||
| * success or rejects on when no item can be found. |
src/CacheInterface.php Outdated
| publicfunctionget($key); | ||
| /** | ||
| * Stores an item in the cache. |
WyriHaximus added a commit to WyriHaximus-labs/cache that referenced this pull request Feb 3, 2018
WyriHaximus added a commit to WyriHaximus-labs/cache that referenced this pull request Feb 3, 2018
WyriHaximus added a commit to WyriHaximus-labs/cache that referenced this pull request Feb 3, 2018
MemberAuthor
WyriHaximus commented Feb 3, 2018
@jsor cheers, fixed the issues you pointed out 👍 |
clue approved these changes Feb 5, 2018
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
LGTM, can you squash this before merging? 👍
MemberAuthor
WyriHaximus commented Feb 5, 2018
jsor approved these changes Feb 5, 2018
WyriHaximusforce-pushed the cache-interface-documentation-current-behavior branch from 6689851 to 37ee805CompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a discussion with @jsor and @clue I've crafted this PR to only describe the current behavior.