Allow legacy HHVM to fail in Travis CI config#36
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
HHVM decided to drop support for PHP, so it's questionable if supporting it in the future is worth the effort. https://hhvm.com/blog/2019/02/11/hhvm-4.0.0.html This PR does not aim to discuss how useful HHVM is and whether or not we want to continue supporting it. It only aims to make the test output consistent by ignoring legacy HHVM fails in the build matrix to not mark the complete test suite as failed. Refs clue/socket-raw#42 and others.
WyriHaximus approved these changes Apr 27, 2019
jsor approved these changes Apr 27, 2019
clue added a commit to clue-labs/reactphp-sqlite that referenced this pull request May 6, 2019
clue added a commit to clue-labs/reactphp-sqlite that referenced this pull request May 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HHVM decided to drop support for PHP, so it's questionable if supporting
it in the future is worth the effort.
https://hhvm.com/blog/2019/02/11/hhvm-4.0.0.html
This PR does not aim to discuss how useful HHVM is and whether or not we
want to continue supporting it. It only aims to make the test output
consistent by ignoring legacy HHVM fails in the build matrix to not mark
the complete test suite as failed.
Refs clue/socket-raw#42 and others.