fix: prevent Process::close() double execution#117
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#116
The
Process::close()method contains a block introducing side effects (seechild-process/src/Process.php
Lines 300 to 302 in 1721e2b
Process::close()method. Due to the deferred protection against double execution of the method (below the block with potential side effects, seechild-process/src/Process.php
Line 310 in 1721e2b
Process::close()method may be run again. The second execution of theProcess::close()method will work correctly, but the first will encounter an error about the absence of a resource in theProcess::$processproperty (this property was set tonullduring the second execution).With this change, the protection against double execution of the
Process::close()method is moved to the very beginning of the method.