Skip to content

Conversation

@clue
Copy link
Member

@clueclue commented Jan 31, 2021

This changeset adds PHP 8 support and support for socket pair descriptors.

The socket pair descriptors are supported as of PHP 8 and provide native, non-blocking I/O support on Windows without any fancy workarounds. The PHP documentation doesn't currently reflect this features, but it's available in the upgrade guide here: https://www.php.net/manual/en/migration80.new-features.php

This changeset includes relevant tests, documentation and examples. In a follow-up PR I'll look into making socket pair descriptors the default for Windows, to make sure this works out-of-the-box on any platform. Explicit configuration will always remain available.

Builds on top of #84, #82, #67 and #65

@clueclue added this to the v0.6.2 milestone Jan 31, 2021
@clue
Copy link
MemberAuthor

clue commented Jan 31, 2021

Updated to work around legacy HHVM which doesn't report pipe open mode. All tests pass now, so this is ready for review :shipit:

@clueclue requested review from WyriHaximus and jsorJanuary 31, 2021 17:22
jsor
jsor approved these changes Feb 1, 2021
@jsorjsor merged commit 2fb5c96 into reactphp:masterFeb 1, 2021
@clueclue deleted the php8 branch February 1, 2021 09:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus