Socket address of closed socket should be null (support PHP 8)#39
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximus approved these changes Feb 2, 2021
clueforce-pushed the php8 branch 2 times, most recently from fed3c2d to ee8f12cCompare
MemberAuthor
clue commented Feb 2, 2021
Temporarily force-pushed test to see if error suppression operators can be removed as per reactphp/socket#246, but failing on legacy HHVM. I've restored the previous version already reviewed by @WyriHaximus (commit IDs are identical). |
jsor approved these changes Feb 2, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #38 and reactphp/socket#246