Support falling back to multiple DNS servers from DNS config#41
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
clue commented Jun 24, 2021
The first commit updates this to the currently unreleased DNS component to show how this feature is used in this component (the build should be green). The second commit updates this to the release that has yet to be tagged. This is expected to fail at the moment and should be green once the release is tagged and the build is restarted. This is ready for review. I will restart the build and merge once reviewed and the DNS component is tagged. |
WyriHaximus approved these changes Jun 25, 2021
clue changed the title MemberAuthor
clue commented Jun 25, 2021
Restarted build and everyhing's green now that reactphp/dns v1.7.0 has been released |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for falling back to multiple DNS servers from DNS config. In other words, if you have multiple DNS servers configured (rare) and connectivity to the primary DNS server is broken (even rarer), it will now fall back to your other DNS servers.
This is done by simply passing the complete list of DNS servers down to the DNS component that is responsible for setting up the DNS executor stack. Accordingly, this builds on top of reactphp/dns#179 and reactphp/dns#180. See also reactphp/socket#257 for the same changes in the socket component.